[PATCH] D67221: [yaml2obj] Write the section header table after section contents

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 01:49:02 PDT 2019


jhenderson added a comment.

Thanks for doing this. I have vague concerns that there might be some tests out there that assume the section header table's position, and somehow rely on it, but are now passing for unrelated reasons to their original intent, but I don't have a good way to check for them short of auditing every yaml2obj user, which seems silly, so I guess we just have to take that risk.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67221/new/

https://reviews.llvm.org/D67221





More information about the llvm-commits mailing list