[PATCH] D67220: [ARM][ParallelDSP] Fix for sext input

[Sam Parker via Phabricator via llvm-commits]

samparker marked 2 inline comments as done.
samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:137
+                                    BasicBlock::iterator(Root));
+        V = Builder.CreateSExt(V, Root->getType());
+      }
----------------
efriedma wrote:
> Is this really the right place to do this?  At this point, we still aren't sure we're going to transform the code.  You could instead just do this after you call getAccumulator() in InsertParallelMACs.
good point.


================
Comment at: test/CodeGen/ARM/ParallelDSP/blocks.ll:1
-; RUN: opt -arm-parallel-dsp -mtriple=armv7-a -S %s -o - | FileCheck %s
+; RUN: opt -arm-parallel-dsp -dce -mtriple=armv7-a -S %s -o - | FileCheck %s
 
----------------
efriedma wrote:
> Why -dce?
Just because it makes it easier for me to write the tests and read the output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67220/new/

https://reviews.llvm.org/D67220