[PATCH] D67206: [ELF][MC] Fix IFunc alias resolving issue

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 00:55:48 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:515
+static bool isIFunc(const MCSymbolELF &Symbol) {
+  if (Symbol.getType() == ELF::STT_GNU_IFUNC)
+    return true;
----------------
Can you change the recursion to a loop?


================
Comment at: llvm/test/MC/ELF/ifunc-alias.s:46
+// CHECK-NEXT:    Name: foo3
+// CHECK-NEXT:    Value: 0x1
+// CHECK-NEXT:    Size: 0
----------------
If Value, Size, Binding, etc are not significant. Delete those CHECK lines. Alternatively, use llvm-readelf -S which has a much conciser output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67206/new/

https://reviews.llvm.org/D67206





More information about the llvm-commits mailing list