[PATCH] D67225: [DebugInfo][X86] Describe call site values for zero-valued imms

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.
Herald added a subscriber: ychen.

Thanks for this! As we have discussed before, this is desirable for sure.

> Having ParamLoadedValue contain a MachineOperand object makes sense to me. This would stave off an explosion of ad hoc OneOperand, TwoOperand, etc forever-objects. And you've demonstrated that the overhead is negligible.
> 
> Looking forward, I also think it makes sense to change the describeLoadedValue API s.t. it's specific about which loaded value is interesting. That can wait until there's a motivating test case.

+1


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67225/new/

https://reviews.llvm.org/D67225