[PATCH] D67250: [WebAssembly] Add fence in __wasm_init_memory

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 20:53:03 PDT 2019


tlively abandoned this revision.
tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lld/wasm/Writer.cpp:733
       //     (i32.const 2)
       //    )
       //    (drop
----------------
aheejin wrote:
> In sequentially consistent models, wouldn't this store serve as the fence anyway?
Yes, you're correct. I confused myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67250/new/

https://reviews.llvm.org/D67250





More information about the llvm-commits mailing list