[PATCH] D66114: [ConstantHoisting] Fix non-determinism.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 18:06:10 PDT 2019


efriedma updated this revision to Diff 219018.
efriedma added a comment.

Got rid of a few changes that were clearly unnecessary, because we never iterated over the maps in question.

It's possible there are more lightweight solutions in a few of these cases.  But anything that affects the order of the modifications performed by ConstantHoisting affects the use lists, at the very least, and the algorithms mostly don't impose any sort of natural ordering.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66114/new/

https://reviews.llvm.org/D66114

Files:
  include/llvm/Transforms/Scalar/ConstantHoisting.h
  lib/Transforms/Scalar/ConstantHoisting.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66114.219018.patch
Type: text/x-patch
Size: 5463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190906/54066956/attachment.bin>


More information about the llvm-commits mailing list