[PATCH] D67244: LangRef: mention MSan's problem with speculative conditional branches.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 16:26:03 PDT 2019


eugenis added inline comments.


================
Comment at: llvm/docs/LangRef.rst:3255-3256
+air". More strictly, an optimization that inserts a conditional branch
+is only valid if in all executions where the branch condition has at
+least one undefined bit, the same branch condition is evaluated in the
+input IR as well.
----------------
lebedev.ri wrote:
> This doesn't parse.
> Either "valid ... at least one defined bit", or "invalid ,,, at least one undefined bit"
We don't care about executions where the condition is defined.
When it is not, the new code has a side effect, therefore the original code needs to have a side effect too.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67244/new/

https://reviews.llvm.org/D67244





More information about the llvm-commits mailing list