[PATCH] D67245: [AArch64][GlobalISel] Always fall back on tail calls with -tailcallopt
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 5 16:26:02 PDT 2019
paquette created this revision.
paquette added a reviewer: aemerson.
Herald added subscribers: Petar.Avramovic, hiraditya, kristof.beyls, javed.absar, rovka.
Herald added a project: LLVM.
`-tailcallopt` requires that we perform different stack adjustments than with sibling calls. For example, the `@caller_to0_from8` function in test/CodeGen/AArch64/tail-call.ll requires that we adjust SP. Without `-tailcallopt`, this adjustment does not happen. With it, however, it is expected.
So, to ensure that adding sibling call support doesn't break `-tailcallopt`, make CallLowering always fall back on possible tail calls when `-tailcallopt` is passed in.
Update test/CodeGen/AArch64/tail-call.ll with a GlobalISel line to make sure that we get the correct code for tail calls with -tailcallopt.
https://reviews.llvm.org/D67245
Files:
llvm/lib/Target/AArch64/AArch64CallLowering.cpp
llvm/test/CodeGen/AArch64/tail-call.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67245.219001.patch
Type: text/x-patch
Size: 6187 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190905/b50b925b/attachment.bin>
More information about the llvm-commits
mailing list