[PATCH] D67244: LangRef: mention MSan's problem with speculative conditional branches.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 16:21:27 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/docs/LangRef.rst:3250
+defines a branch with condition that depends on an undef value (or
+certain other values, like ex. a result of a load from heap-allocated
+memory that has never been stored to) to have an externally visible
----------------
s/ex./e.g./


================
Comment at: llvm/docs/LangRef.rst:3255-3256
+air". More strictly, an optimization that inserts a conditional branch
+is only valid if in all executions where the branch condition has at
+least one undefined bit, the same branch condition is evaluated in the
+input IR as well.
----------------
This doesn't parse.
Either "valid ... at least one defined bit", or "invalid ,,, at least one undefined bit"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67244/new/

https://reviews.llvm.org/D67244





More information about the llvm-commits mailing list