[PATCH] D66024: [SVFS] Vector Function ABI name demangler.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked 6 inline comments as done.
fpetrogalli added a comment.

Hi @sdesmalen:

>   it would be better to parse the mangled string incrementally, rather than extracting each feature from the string individually.

I think the parser now does what you ask for the "variable length" part of the mangled string, which is the one that holds the `<vlen>` and the `<parameters>`.

Francesco



================
Comment at: llvm/tools/vfabi-demangle-fuzzer/vfabi-demangler-fuzzer.cpp:19
+  const StringRef MangledName((const char *)Data, Size);
+  const StringRef A = VFABI::VectorFunctionShape::getVectorName(MangledName);
+  const StringRef B =
----------------
lebedev.ri wrote:
> Question: does `getVectorName()` run *all* of the parsing code in `SearchVectorFunctionSystem.cpp`?
Good catch. Now it does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66024/new/

https://reviews.llvm.org/D66024