[PATCH] D67205: [SimplifyCFG] Don't SimplifyBranchOnICmpChain with ExtraCase

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

You description of the issue uses "||" in the pseudo-code; I assume you actually mean a non-short-circuiting "|"?

Is there a general description somewhere of what restrictions msan places on IR transforms vs. normal IR semantics?  It's not obvious to me that this transform, specifically, is incorrect, as opposed to whatever transform is producing this IR.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:3743
+    if (BB->getParent()->hasFnAttribute(Attribute::SanitizeMemory))
+      return false;
     BasicBlock *NewBB =
----------------
Can you fix this so we return early before the LLVM_DEBUG log?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67205/new/

https://reviews.llvm.org/D67205