[PATCH] D67207: [JumpThreading] Fix the AssertVH handling for debug builds.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

It seems like there are multiple problems here if "BB" gets deleted eagerly: there the AssertingVH failure you're mentioning here, LVI->eraseBlock doesn't work, and the for loop "for (auto &BB : F)" also breaks.  So I don't think this patch really solves anything.

Maybe it makes sense to change the TryToSimplifyUncondBranchFromEmptyBlock API so it doesn't erase the basic block, then call DeleteDeadBlock after we've cleaned up LVI etc.?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67207/new/

https://reviews.llvm.org/D67207