[PATCH] D67097: [DWARF] Check for format mismatch between CU and Range List Table.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 11:57:16 PDT 2019


probinson added a comment.

In D67097#1658363 <https://reviews.llvm.org/D67097#1658363>, @dblaikie wrote:

> In D67097#1657964 <https://reviews.llvm.org/D67097#1657964>, @probinson wrote:
>
> > In D67097#1656268 <https://reviews.llvm.org/D67097#1656268>, @dblaikie wrote:
> >
> > > I'm not sure if using "OffsetIn" in the diagnostic is the right thing to do.
> > >
> > > Honestly the fact that DWARFv5 specifies that the "rnglist base address" (& loclist bast address, and str_offsets base) point to the beginning of the list rather than the start of the header is super quirky and I don't think it's helpful to users to highlight that. (though I doubt DWARFvNext would bother fixing this - it'sjust quirky, not super problematic for any practical reasons I can think of)
> >
> >
> > IIRC this is one of Cary's, and argued that it could be directly used to index into section, instead of you having to step past the header to use it.  Anyway we let him get away with it, for better or worse.
>
>
> Meh, I can't imagine the (Start+Header)[N] would be too expensive (& Start+Header could be computed once/ahead of time easily enough).


By that argument, computing (Start-Header) is not expensive and so why is it worth changing?  For aesthetics?  If it bugs you that much, you can write the proposal and post it to dwarfstd.org; it doesn't have to include the edit to the wording, just "these attributes should point here instead of there."

>> It would have to be essentially unusable or horribly inefficient, for the committee to be willing to change it now.
> 
> Not sure what would be unusable or inefficient about it - could you explain more?

(rewrite) There isn't anything terribly unusable or inefficient about it, so unless somebody really complains, the committee is unlikely to change it now.  This isn't the C++ committee, after all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67097/new/

https://reviews.llvm.org/D67097





More information about the llvm-commits mailing list