[PATCH] D67209: [MIR] MIR Namer pass

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRNamerPass.cpp:9
+//
+// The purpose of this pass is to renames virtual register operands.
+//
----------------
s/renames/rename/

Might want to explain what the use-cases for this are too. E.g. test development


================
Comment at: llvm/lib/CodeGen/MIRNamerPass.cpp:41
+  StringRef getPassName() const override {
+    return "Rename virtual register operands.";
+  }
----------------
I don't think these usually have a period at the end?


================
Comment at: llvm/lib/CodeGen/MIRNamerPass.cpp:58
+    ReversePostOrderTraversal<MachineBasicBlock *> RPOT(&*MF.begin());
+    for (auto MBB : RPOT)
+      Changed |= NVC.renameVRegs(MBB);
----------------
`auto &MBB`?


================
Comment at: llvm/test/CodeGen/MIR/AArch64/mirnamer.mir:1
+# RUN: llc -mtriple aarch64-apple-ios -run-pass mir-namer -o - %s | FileCheck %s
+
----------------
-verify-machineinstrs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67209/new/

https://reviews.llvm.org/D67209