[PATCH] D67182: [lib/ObjectYAML] - Improve and cleanup error reporting in ELFState<ELFT> class.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 06:36:04 PDT 2019


grimar updated this revision to Diff 218905.
grimar marked 10 inline comments as done.
grimar added a comment.

- Addressed review comments, added test cases.
- Added single quotes around symbol name in the error message: "unknown section referenced ... by YAML symbol 'X'". This matches another messages tool reports.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67182/new/

https://reviews.llvm.org/D67182

Files:
  lib/ObjectYAML/ELFEmitter.cpp
  test/tools/yaml2obj/duplicate-section-names.test
  test/tools/yaml2obj/duplicate-symbol-names.test
  test/tools/yaml2obj/dynamic-section-raw-content.yaml
  test/tools/yaml2obj/dynamic-symbols.yaml
  test/tools/yaml2obj/dynsymtab-implicit-sections-size-content.yaml
  test/tools/yaml2obj/elf-comdat-broken-info.yaml
  test/tools/yaml2obj/elf-custom-null-section.yaml
  test/tools/yaml2obj/program-header.yaml
  test/tools/yaml2obj/relocation-missing-symbol.yaml
  test/tools/yaml2obj/symtab-implicit-sections-size-content.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67182.218905.patch
Type: text/x-patch
Size: 34123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190905/9a76f956/attachment.bin>


More information about the llvm-commits mailing list