[PATCH] D67221: [yaml2obj] Write the section header table after section contents
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 5 06:21:23 PDT 2019
grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: test/tools/llvm-objcopy/ELF/overlapping-sections-in-segments.test:13
+## (e_shoff+64*2+24 = 0x10e8) overlap the first one.
+# RUN: %python -c "with open('%/t.o', 'r+b') as input: import struct; bytes = struct.pack('<Q', 0x1001); input.seek(0x10e8); input.write(bytes)"
----------------
Seems we should be able to rewrite this and "overlapping-sections.test" tests to use just YAML, since we have override the sh_offset now. I'll try to do this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67221/new/
https://reviews.llvm.org/D67221
More information about the llvm-commits
mailing list