[PATCH] D67221: [yaml2obj] Write the section header table after section contents

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lib/ObjectYAML/ELFEmitter.cpp:1060
+  Elf_Ehdr Header;
+  uint64_t SHOff;
+  CBA.getOSAndAlignedOffset(SHOff, sizeof(typename ELFT::uint));
----------------
grimar wrote:
> Side note: we are not consistent in naming... we have `ShOffset` vs `SHOffset` and what is worse `IO.mapOptional("SHOffset", FileHdr.SHOffset);` vs `IO.mapOptional("ShOffset", Section.ShOffset)`
Changed to ShOffset


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67221/new/

https://reviews.llvm.org/D67221