[PATCH] D67210: [x86] bug fix for https://reviews.llvm.org/D64551

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 5 05:43:33 PDT 2019


RKSimon added a comment.

Please abandon this, it isn't a valid solution to the issue (raised at PR43227). I have a WIP fix that will address this correctly.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:7681
+    if (!ISD::isNON_EXTLoad(Elt.getNode()))
+      return SDValue();
     // Each loaded element must be the correct fractional portion of the
----------------
This misses the entire point of D64551 which adds support for drilling down through other ops to find a NON_EXTLoad with a byte offset.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67210/new/

https://reviews.llvm.org/D67210





More information about the llvm-commits mailing list