[PATCH] D66936: [DFAPacketizer] Track resources for packetized instructions

[James Molloy via Phabricator via llvm-commits]

jmolloy marked an inline comment as done.
jmolloy added a comment.

Hi Thomas,

Thanks for the review!
You're right, we do actually use this in Hexagon (we dump the output so it can be read by FileCheck). Perhaps we should only do this #ifndef NDEBUG.

James



================
Comment at: lib/CodeGen/DFAPacketizer.cpp:269
+      for (MachineInstr *MI : CurrentPacketMIs) {
+        unsigned R = ResourceTracker->getUsedResources(Idx++);
+        dbgs() << " * [res:0x" << utohexstr(R) << "] " << *MI;
----------------
ThomasRaoux wrote:
> This would assert if tracking is off. Is this done on purpose?
Yes, so that we can FileCheck this output and verify the tracking is working. VLIWPacketizer sets tracking on always in the constructor, above.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66936/new/

https://reviews.llvm.org/D66936