[PATCH] D67212: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: clang/lib/Headers/ia32intrin.h:198
 
+static __inline__ unsigned int __attribute__((__always_inline__))
+_castf32_u32(float __Bits) {
----------------
There's an unofficial agreement that new x86 intrinsics should have doxygen comments - someday we'll get around to adding them to the existing ones as well.....


================
Comment at: clang/lib/Headers/ia32intrin.h:207
+_castf64_u64(double __Bits) {
+  unsigned long long D;
+  __builtin_memcpy(&D, &__Bits, sizeof(__Bits));
----------------
Shouldn't the unsigned long long cases be hidden by __x86_64__ wrappers?


================
Comment at: clang/test/CodeGen/miscellaneous-builtins.c:1
+// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-unknown -emit-llvm -o - -Wall -Werror | FileCheck %s
+
----------------
32-bit target tests?


================
Comment at: clang/test/CodeGen/miscellaneous-builtins.c:32
+}
\ No newline at end of file

----------------
newline please


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67212/new/

https://reviews.llvm.org/D67212