[PATCH] D66967: [Attributor] ValueSimplify Abstract Attribute

[Hideto Ueno via Phabricator via llvm-commits]

uenoku marked an inline comment as done.
uenoku added inline comments.


================
Comment at: llvm/test/Transforms/FunctionAttrs/value-simplify.ll:117
+  ; CHECK: tail call void @use(i32 %select-not-same-undef)
+  tail call void @use(i32 %select-not-same-undef)
+
----------------
jdoerfert wrote:
> This should arguably be
>   `; CHECK: tail call void @use(i32 %phi-not-same)`
> The pessimistic fixpoint should probably not revert to `nullptr` and cause a cascading failure but instead just go back to the original value.
>
> This should arguably be
> 
> `; CHECK: tail call void @use(i32 %phi-not-same)`
In genericTraversal, `%phi-not-same` is  decomposed to i32 0, 1 so I think it is not currect.

> The pessimistic fixpoint should probably not revert to nullptr and cause a cascading failure but instead just go back to the original value.
It looks good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66967/new/

https://reviews.llvm.org/D66967