[PATCH] D67144: [llvm-objcopy] Default --output-target to --input-target when unspecified

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D67144#1658101 <https://reviews.llvm.org/D67144#1658101>, @jakehehrlich wrote:

> If our intent is to prefer using -O over -B when possible (as seems to be the case) then this all looks good to me. I just want an explanation if one exists.


I prefer `-O` to `-B`.

`{llvm-,}objcopy -O binary a.o a.txt` can extract the text file. There is no `-B` alternative, so `-O` has to be kept around.

After this change, we can essentially ignore `-B`, like what elftoolchain (used by FreeBSD) does:

  case 'B':
    /* ignored */
    break;
    ...
  case 'I':
  case 's':
    set_input_target(ecp, optarg);
    break;
    ...
  case 'O':
    set_output_target(ecp, optarg);
    break;


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67144/new/

https://reviews.llvm.org/D67144