[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 22:57:18 PDT 2019


MaskRay added inline comments.


================
Comment at: lib/DebugInfo/GSYM/Range.cpp:46
+bool AddressRanges::contains(AddressRange Range) const {
+  if (Range.size() == 0)
+    return false;
----------------
Do you know why it returns false if `Range.size() == 0`?

If I remove `Range.size() == 0`, the following test will break

```
EXPECT_FALSE(Ranges.contains(AddressRange(0x1000, 0x1000)));
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600





More information about the llvm-commits mailing list