[PATCH] D57836: [Intrinsic] Unsigned Fixed Point Saturation Multiplication Intrinsic

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope marked 2 inline comments as done.
bjope added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6810
+  APInt MaxVal = APInt::getSignedMaxValue(VTSize);
+  SDValue LowMask = DAG.getConstant(APInt::getLowBitsSet(VTSize, Scale - 1),
+                                    dl, VT);
----------------
bjope wrote:
> This does not work for Scale==0 (and we might pass through the special handling for Scale==0 above. The same problem exists in the old code.
> I'll need to look into this a bit more.
Fix for that is in https://reviews.llvm.org/D67071


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57836/new/

https://reviews.llvm.org/D57836