[PATCH] D67152: Align output segments correctly

Wed Sep 4 21:59:26 PDT 2019

MaskRay added inline comments.

================
Comment at: lld/test/ELF/nmagic.s:22
+.rodata
+.align 8
+.quad 42
----------------
ruiu wrote:
> MaskRay wrote:
> > If I assemble this file as x86-64, .rodata happens to be aligned without the change. A larger alignment make more likely reveal problems if we have some layout changes.
> That is true, but this file should suffice to reveal the bug, and it also captures the real usage, so I want to keep this as-is.
Since `-Ttext 0` is used, no layout change can affect the addresses. I think keeping it as-is is fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67152/new/

https://reviews.llvm.org/D67152