[PATCH] D67206: [ELF][MC] Fix IFunc alias resolving issue

[Sr.Zhang via Phabricator via llvm-commits]

zsrkmyn added inline comments.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:539
   uint8_t Type = Symbol.getType();
+  if (Type == ELF::STT_NOTYPE && isIFunc(Symbol))
+    Type = ELF::STT_GNU_IFUNC;
----------------
MaskRay wrote:
> GNU as doesn't check the type of the alias
> 
> ```
> .type foo2, @function
> .set foo2,foo   # foo2 is a STT_GNU_IFUNC
> ```
I'm sorry, but do you mean that I need to remove the '.type' directive in the test or that the IFunc check I do here is wrong? :D


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67206/new/

https://reviews.llvm.org/D67206