[PATCH] D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 17:09:46 PDT 2019


compnerd added a comment.

@beanz - I can see where you are coming from there.  But, the thing is that when you are building for a wide variety of targets at once, that doesn't make sense since not all the runtimes are compatible with all targets (e.g. unwind doesn't support Windows).  Calculating the set difference and passing that along seems more complicated, though plausible.  Note that this approach preserves the existing behaviour - unless you *explicitly* state the runtimes for a specific target, the `LLVM_ENABLE_RUNTIMES` passed globally will continue to be passed through, so from a user's perspective nothing has changed (and that is intentional - no one should need to update their CMake caches for this change).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67195/new/

https://reviews.llvm.org/D67195





More information about the llvm-commits mailing list