[PATCH] D66859: [index-while-buildling] FSUtil

[Jan Korous via Phabricator via llvm-commits]

jkorous added a comment.

In D66859#1650481 <https://reviews.llvm.org/D66859#1650481>, @gribozavr wrote:

> In D66859#1649868 <https://reviews.llvm.org/D66859#1649868>, @jkorous wrote:
>
> > Hmm, actually if we replace `Buffer` in the interface with a `llvm::function_ref<void(llvm::raw_ostream &)>` callback it would cover couple other existing uses of `createUniqueFile`.
>
>
> That would make a lot of sense if you're going to do the cleanup and refactor those callers to use new API. Good idea!
>
> However, I think just from the API simplicity perspective, it would make sense to have two overloaded APIs if calling this function with a precomputed buffer is common.


Ok. I'll land this simple version first and will take a look at the overload next week.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66859/new/

https://reviews.llvm.org/D66859