[PATCH] D67199: [InstCombine] Expand the simplification of log()

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:2888
     case Intrinsic::log:
+    case Intrinsic::log2:
       return optimizeLog(CI, Builder);
----------------
evandro wrote:
> efriedma wrote:
> > not Intrinsic::log10?
> We don't have one yet.
LangRef says we have one; is it wrong?


================
Comment at: llvm/test/Transforms/InstCombine/log-pow.ll:93
   %exp = call fast float @exp2f(float %x)
-  %log = call fast float @log10f(float %exp)
   ret float %log
----------------
evandro wrote:
> efriedma wrote:
> > I'm not sure why you want to remove test coverage for log10f?
> `log10g()` is actually tested elsewhere and this results in a more radical simplification.
Okay.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67199/new/

https://reviews.llvm.org/D67199