[PATCH] D67090: [llvm-objcopy][llvm-strip] Support --only-keep-debug

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

We should certainly check perf. I'd also like to wait on this until Roland gets back in order for him to chime in since he had specific examples of use cases where program headers are required as I recall. Specifically the section virtual addresses are not sufficient in the arcane case of prelinking but prelinking isn't really something I know very much about.



================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:1791
+ELFWriter<ELFT>::ELFWriter(const CopyConfig &Config, Object &Obj, Buffer &Buf)
+    : Writer(Obj, Buf), Config(Config),
+      WriteSectionHeaders(!Config.StripSections && Obj.HadShdrs) {}
----------------
ELFWriter is never allowed to depend on Config but you're more than welcome to add a flag of some kind to it to know if OnlyKeepDebug is being used.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67090/new/

https://reviews.llvm.org/D67090