[PATCH] D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

@jmolloy / @RKSimon / @efriedma - thoughts?

In D65148#1656154 <https://reviews.llvm.org/D65148#1656154>, @xbolva00 wrote:

> There were/are(?) regressions even with 2...
>
> https://bugs.llvm.org/show_bug.cgi?id=22616


Sure it did. Thanks for digging that up.
Honestly all graphics computations are always horrible to do on scalars,
those should (and almost always can be) vectorized, minimizing branching
as much as possible, replacing it with blending, which essentially is
what that patch did, except that the code remained scalar...
So the patch was doing the right thing there, "in general".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65148/new/

https://reviews.llvm.org/D65148