[PATCH] D67193: [UBSan] Do not overwrite the default print_summary sanitizer option.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 13:56:34 PDT 2019


Dor1s created this revision.
Dor1s added reviewers: hctim, samsonov, morehouse.
Herald added subscribers: Sanitizers, delcypher.
Herald added projects: LLVM, Sanitizers.

This option is true by default in sanitizer common. The default
false value was added a while ago without any reasoning in
https://github.com/llvm-mirror/compiler-rt/commit/524e934112a593ac081bf2b05aa0d60a67987f05

so, presumably it's safe to remove for consistency.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D67193

Files:
  lib/ubsan/ubsan_flags.cpp


Index: lib/ubsan/ubsan_flags.cpp
===================================================================
--- lib/ubsan/ubsan_flags.cpp
+++ lib/ubsan/ubsan_flags.cpp
@@ -54,7 +54,6 @@
   {
     CommonFlags cf;
     cf.CopyFrom(*common_flags());
-    cf.print_summary = false;
     cf.external_symbolizer_path = GetFlag("UBSAN_SYMBOLIZER_PATH");
     OverrideCommonFlags(cf);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67193.218785.patch
Type: text/x-patch
Size: 375 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190904/dfdc4b9a/attachment.bin>


More information about the llvm-commits mailing list