[PATCH] D54368: RegAllocFast: Record internal state based on register units

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 12:31:45 PDT 2019


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.

Suggestion of a small refactoring below.



================
Comment at: lib/CodeGen/RegAllocFast.cpp:434
+           "Broken RegState mapping");
+#endif
 
----------------
Maybe we can factor this code out into a verify kind of thing.
Like one that returns a bool that we wrap into an assert here and in the killVirtReg.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54368/new/

https://reviews.llvm.org/D54368





More information about the llvm-commits mailing list