[PATCH] D65783: [WebAssembly] Initialize memory in start function

[Thomas Lively via Phabricator via llvm-commits]

tlively marked 2 inline comments as done.
tlively added inline comments.


================
Comment at: lld/wasm/Writer.cpp:711
+      //
+      // (block
+      //  (if
----------------
aheejin wrote:
> I can't find this `block` instruction in the code. Am I missing something?
I wrote this wat using Binaryen's text format, which requires a block here that is not present in the binary. I will rewrite the wat using the standard text format, which will be less confusing.


================
Comment at: lld/wasm/Writer.cpp:720
+      //    (i32.atomic.wait align=2 offset=0
+      //     (i32.const $flag)
+      //     (i32.const 1)
----------------
aheejin wrote:
> Nit: How about `$__init_memory_flag` for consistency?
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65783/new/

https://reviews.llvm.org/D65783