[PATCH] D67114: [mir-canon][NFC] Move MIR Vreg renaming code to separate file for better reuse.

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM with some nits on comments.



================
Comment at: llvm/lib/CodeGen/MIRVRegNamerUtils.h:35
+  unsigned virtualVRegNumber;
+  const unsigned SkipGapSize;
+  std::vector<Register> RenamedInOtherBB;
----------------
Judging by the SkipGapSize comment below, I think you wanted to document this?

I guess it's probably a good idea anyway, considering you can initialize it etc?


================
Comment at: llvm/lib/CodeGen/MIRVRegNamerUtils.h:45-46
+
+  /// SkipGapSize - Skips modulo a gap value of indices. Indices are used to
+  /// produce the next vreg name.
+  void skipVRegs();
----------------
s/SkipGapSize/skipVRegs/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67114/new/

https://reviews.llvm.org/D67114