[PATCH] D67105: [TargetLowering] Fix another potential FPE in expandFP_TO_UINT
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 4 10:17:07 PDT 2019
uweigand added a comment.
So this removes the attempted handling of constant arguments. I agree with @efriedma that it doesn't make sense to just do this small optimization; we should really constant fold.
As long as this constant-folding is not yet implemented, the test cases using constant arguments will now have more complex code (similarly to what they'd have with variable arguments). Not sure if that is really an issue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67105/new/
https://reviews.llvm.org/D67105
More information about the llvm-commits
mailing list