[PATCH] D62868: [libc++] Always build with -fvisibility=hidden

Wed Sep 4 09:41:09 PDT 2019

ldionne added a comment.

In D62868#1657521 <https://reviews.llvm.org/D62868#1657521>, @ldionne wrote:

> In D62868#1656807 <https://reviews.llvm.org/D62868#1656807>, @mgorny wrote:
>
> > In D62868#1650892 <https://reviews.llvm.org/D62868#1650892>, @ldionne wrote:
> >
> > > Quick update for watchers:
> > >
> > > The bug mentioned by Peter has been fixed now, but I'm looking into other link errors when using GCC (because there's more).
> >
> >
> > Ping. What's the progress? Unless I'm mistaken, all libc++ failures on our buildbot are related to this: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22010
>
>
> https://reviews.llvm.org/D66970 would fix the issue, but I'm waiting on a review. I'll check-in a minimal fix to the problem in the meantime.

https://reviews.llvm.org/rCXX370926 should fix the problem

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62868/new/

https://reviews.llvm.org/D62868