[PATCH] D67164: [ELF] Don't shrink RelrSection

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 09:20:39 PDT 2019


MaskRay added a comment.

In D67164#1657824 <https://reviews.llvm.org/D67164#1657824>, @peter.smith wrote:

> As far as I can tell this will definitely prevent the oscillation and has already seen success in the Android relocation side. As Rui mentioned on the PR, it would be useful to put a generic convergence limit on finalizeAddressDependentContent() to catch an infinite loop that we'd not thought possible. This could be done separately though.


Thanks! As grimar suggested, we may need some `log()` in these iterating loops as well.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67164/new/

https://reviews.llvm.org/D67164





More information about the llvm-commits mailing list