[PATCH] D67144: [llvm-objcopy] Default --output-target to --input-target when unspecified

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/binary-input-and-output.test:22
+## -B is ignored if -O is "binary".
+# RUN: llvm-objcopy -I binary -B i386:x86-64 -O binary %t.txt %t.3.txt
 # RUN: cmp %t.txt %t.3.txt
----------------
%t.3.txt -> %t.5.txt here and the line below.


================
Comment at: test/tools/llvm-objcopy/ELF/binary-output-target.test:18-19
 
-# RUN: llvm-objcopy -I binary -B powerpc:common64 %t.txt %t.powerpc_common64.o
-# RUN: llvm-readobj --file-headers %t.powerpc_common64.o | FileCheck %s --check-prefixes=CHECK,LE,PPC,64
+# RUN: llvm-objcopy -I binary -O elf32-powerpc %t.txt %t.ppc.o
+# RUN: llvm-readobj --file-headers %t.ppc.o | FileCheck %s --check-prefixes=CHECK,BE,PPC,32
 
----------------
Was this case just missing before? Maybe worth making this change independently.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67144/new/

https://reviews.llvm.org/D67144