[PATCH] D66958: [AMDGPU] Enable constant offset promotion to immediate operand for VMEM stores

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin marked an inline comment as done.
vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:1326
 
-  // TODO: Support Store.
-  if (!MI.mayLoad())
+  if (MI.mayLoad() && TII->getNamedOperand(MI, AMDGPU::OpName::vdata) != NULL)
     return false;
----------------
rampitec wrote:
> rampitec wrote:
> > nullptr or !TII->getNamedOperand()
> Stores also have vdata, aren't they?
this was done to save the original semantic for mayLoad checks, I'm not sure why it is used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66958/new/

https://reviews.llvm.org/D66958