[PATCH] D67164: [ELF] Don't shrink RelrSection

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 07:46:26 PDT 2019


grimar added inline comments.


================
Comment at: test/ELF/pack-dyn-relocs-relr-loop.s:11
+## The test is very sensitive to the exact section sizes and offsets,
+## make sure .data is located at a page boundary.
+
----------------
Just an idea, not sure how much is reasonable:

LLD sometimes calls `log()` and `print()`.
The latter is used to test ICF:

# CHECK: selected section {{.*}}:(.text.f1)
# CHECK:   removing identical section {{.*}}:(.text.f2)

You can probably add a `log()` call and `-v` and check that resize happened.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67164/new/

https://reviews.llvm.org/D67164





More information about the llvm-commits mailing list