[PATCH] D67170: [Attributor] Ensure AAIsDead correctly overrides getIRPosition

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 07:10:25 PDT 2019


RKSimon created this revision.
RKSimon added reviewers: jdoerfert, sstefan1.
Herald added a project: LLVM.

As commented on D65712 <https://reviews.llvm.org/D65712>, the getIRPosition methods weren't correctly being overridden.


Repository:
  rL LLVM

https://reviews.llvm.org/D67170

Files:
  include/llvm/Transforms/IPO/Attributor.h


Index: include/llvm/Transforms/IPO/Attributor.h
===================================================================
--- include/llvm/Transforms/IPO/Attributor.h
+++ include/llvm/Transforms/IPO/Attributor.h
@@ -1418,8 +1418,8 @@
   /// Return an IR position, see struct IRPosition.
   ///
   ///{
-  IRPosition &getIRPosition() { return *this; }
-  const IRPosition &getIRPosition() const { return *this; }
+  IRPosition &getIRPosition() override { return *this; }
+  const IRPosition &getIRPosition() const override { return *this; }
   ///}
 
   /// Create an abstract attribute view for the position \p IRP.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67170.218685.patch
Type: text/x-patch
Size: 620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190904/c3802dbe/attachment.bin>


More information about the llvm-commits mailing list