[PATCH] D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Looks horrible, please commit :)



================
Comment at: llvm/lib/Object/WindowsResource.cpp:316
+         Entry.getNameID() == /* CREATEPROCESS_MANIFEST_RESOURCE_ID */ 1 &&
+         Entry.getLanguage() == 0;
+}
----------------
Should these check for mingw? A normal user-provided resource could probably conceivably have language id 0 as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66825/new/

https://reviews.llvm.org/D66825