[PATCH] D67152: Align output segments correctly

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/nmagic.s:4
+
+# RUN: llvm-mc -filetype=obj -triple=i386-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -o %t.exe -N -Ttext 0
----------------
`-unknown-linux` can be deleted.


================
Comment at: lld/test/ELF/nmagic.s:5
+# RUN: llvm-mc -filetype=obj -triple=i386-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -o %t.exe -N -Ttext 0
+# RUN: llvm-readelf -section-headers %t.exe | FileCheck %s
----------------
Use `-n` for a nmagic test.. (`-N` is omagic which does more)


================
Comment at: lld/test/ELF/nmagic.s:6
+# RUN: ld.lld %t.o -o %t.exe -N -Ttext 0
+# RUN: llvm-readelf -section-headers %t.exe | FileCheck %s
+
----------------
-S or `--section-headers`. The single-dash form `-long-option` is deprecated in llvm binutils that intend to match GNU binutils.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67152/new/

https://reviews.llvm.org/D67152