[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D64146#1657146 <https://reviews.llvm.org/D64146#1657146>, @lebedev.ri wrote:

> In D64146#1657117 <https://reviews.llvm.org/D64146#1657117>, @svenvh wrote:
>
> > Shared library builds seem to be broken indeed.  I tried fixing by adding `Support` and `clangAST` as dependencies for `clangInterp`, but that creates a cyclic dependency between `clangAST` <-> `clangInterp`.  Which makes me wonder whether `clangInterp` should be a separate library or be part of `clangAST`?
>
>
> Arrived at same conclusions, reverted in rL370874 <https://reviews.llvm.org/rL370874>.


And that was even pointed out several days ago before the patch got relanded last **//two//** times:

In D64146#1653221 <https://reviews.llvm.org/D64146#1653221>, @teemperor wrote:

> Seems like this patch introduced a cyclic dependency between Basic and AST when building with LLVM_ENABLE_MODULES=On:
>
>   While building module 'Clang_AST' imported from llvm/lldb/include/lldb/Symbol/ClangUtil.h:14:
>   While building module 'Clang_Basic' imported from llvm/llvm/../clang/include/clang/AST/Stmt.h:18:
>   In file included from <module-includes>:73:
>   clang/include/clang/Basic/OptionalDiagnostic.h:17:10: fatal error: cyclic dependency in module 'Clang_AST': Clang_AST -> Clang_Basic -> Clang_AST
>   #include "clang/AST/APValue.h"
>


@nand Please don't reland this patch until these concerns are addressed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64146/new/

https://reviews.llvm.org/D64146