[PATCH] D67146: [yaml2obj] Support PT_GNU_STACK and PT_GNU_RELRO

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 218617.
MaskRay edited the summary of this revision.
MaskRay added a comment.
Herald added subscribers: seiya, jakehehrlich, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: rupprecht.

Update a test test/tools/llvm-objcopy/ELF/marker-segment.test to use PT_GNU_STACK
Add numbers beside `Type: PT_*`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67146/new/

https://reviews.llvm.org/D67146

Files:
  lib/ObjectYAML/ELFYAML.cpp
  test/tools/llvm-objcopy/ELF/marker-segment.test
  test/tools/yaml2obj/program-header.yaml


Index: test/tools/yaml2obj/program-header.yaml
===================================================================
--- test/tools/yaml2obj/program-header.yaml
+++ test/tools/yaml2obj/program-header.yaml
@@ -37,6 +37,9 @@
     PAddr: 0xFFFF2000
     Sections:
       - Section: .data
+  - Type: PT_GNU_EH_FRAME
+  - Type: PT_GNU_STACK
+  - Type: PT_GNU_RELRO
 
 #CHECK:     ProgramHeaders [
 #CHECK-NEXT:   ProgramHeader {
@@ -64,6 +67,15 @@
 #CHECK-NEXT:    ]
 #CHECK-NEXT:    Alignment: 4096
 #CHECK-NEXT:  }
+#CHECK-NEXT:  ProgramHeader {
+#CHECK-NEXT:    Type: PT_GNU_EH_FRAME (0x6474E550)
+#CHECK:       }
+#CHECK-NEXT:  ProgramHeader {
+#CHECK-NEXT:    Type: PT_GNU_STACK (0x6474E551)
+#CHECK:       }
+#CHECK-NEXT:  ProgramHeader {
+#CHECK-NEXT:    Type: PT_GNU_RELRO (0x6474E552)
+#CHECK:       }
 #CHECK-NEXT:]
 
 ## Check we do not allow referencing sections that do not exist.
Index: test/tools/llvm-objcopy/ELF/marker-segment.test
===================================================================
--- test/tools/llvm-objcopy/ELF/marker-segment.test
+++ test/tools/llvm-objcopy/ELF/marker-segment.test
@@ -43,7 +43,7 @@
     Align: 0x1000
     Sections:
       - Section: .data
-  - Type: 0x6474e551 # GNU_STACK
+  - Type: PT_GNU_STACK
     Flags: [ PF_R, PF_W ]
     VAddr: 0x0000
     PAddr: 0x0000
Index: lib/ObjectYAML/ELFYAML.cpp
===================================================================
--- lib/ObjectYAML/ELFYAML.cpp
+++ lib/ObjectYAML/ELFYAML.cpp
@@ -52,6 +52,8 @@
   ECase(PT_PHDR);
   ECase(PT_TLS);
   ECase(PT_GNU_EH_FRAME);
+  ECase(PT_GNU_STACK);
+  ECase(PT_GNU_RELRO);
 #undef ECase
   IO.enumFallback<Hex32>(Value);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67146.218617.patch
Type: text/x-patch
Size: 1658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190904/60b7a9f0/attachment.bin>