[PATCH] D67121: [TargetLowering] Make allowsMemoryAccess methode virtual.

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 4 01:53:08 PDT 2019


jmolloy added a comment.

> On the other hand, I don't really want to spend much time thinking about how to make SelectionDAG better at this point.

I agree, that's kind of my worry with opening this pandora's box. Changing hooks in SDAG and maintaining performance parity is very hard, and we have a longer term solution in Global Isel.

Given that, and given the NFC-ness of this patch, are you happy for it to go in?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67121/new/

https://reviews.llvm.org/D67121





More information about the llvm-commits mailing list