[PATCH] D67109: [ARM] Add patterns for CTLZ on MVE

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/mve-ctlz.ll:34
+
+declare <4 x i32> @llvm.ctlz.v4i32(<4 x i32>)
+declare <8 x i16> @llvm.ctlz.v8i16(<8 x i16>)
----------------
I believe these intrinsics should take an extra i1 parameter specifying whether an input of 0 in undef or not. The MVE instructions should produce sensible values for an input of 0, as far as I understand, so they should both lower to the same thing. Worth adding tests for both.

We might as well add tests for v2i64 too, just to show that they are doing something that doesn't look wrong.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67109/new/

https://reviews.llvm.org/D67109