[PATCH] D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

just want to mention a slightly different approach:

CopyConfig.h:

  // Forward declarations only.
  struct COFFCopyConfig;
  struct ELFCopyConfig;
  struct MachOCopyConfig;
  
  struct CopyConfig {
      ...
     Optional<StringRef> NewSymbolVisibility;
     std::vector<StringRef> SymbolsToAdd;
    
     std::unique_ptr<COFFCopyConfig> COFF;
     std::unique_ptr<ELFCopyConfig> ELF;
     std::unique_ptr<MachOCopyConfig> MachO;
  };

ELFObjcopy.h:

  struct ELFCopyConfig {
     Optional<uint8_t> NewSymbolVisibility;
     std::vector<NewSymbolInfo> SymbolsToAdd
  };
  
  Error parseELFCopyConfig(CopyConfig &C);
  
  Error executeObjcopyOnBinary(
       CopyConfig &CommonConfig,
       object::ELFObjectFileBase &In, Buffer &Out);

What do you think ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67139/new/

https://reviews.llvm.org/D67139