[PATCH] D65783: [WebAssembly] Initialize memory in start function

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 3 22:22:27 PDT 2019


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM % nits if tests pass.



================
Comment at: lld/wasm/Writer.cpp:711
+      //
+      // (block
+      //  (if
----------------
I can't find this `block` instruction in the code. Am I missing something?


================
Comment at: lld/wasm/Writer.cpp:720
+      //    (i32.atomic.wait align=2 offset=0
+      //     (i32.const $flag)
+      //     (i32.const 1)
----------------
Nit: How about `$__init_memory_flag` for consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65783/new/

https://reviews.llvm.org/D65783





More information about the llvm-commits mailing list